Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pg_cardano and CFD to Builder Tools #1345

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Fell-x27
Copy link
Contributor

Checklist

Builder Tool addition

@rphair rphair changed the title pg_cardano and CFD added; Add pg_cardano and CFD to Builder Tools Oct 18, 2024
@rphair rphair added the builder tool Indicates a PR/issue on a builder tool label Oct 18, 2024
@rphair
Copy link
Collaborator

rphair commented Oct 18, 2024

FYI @Fell-x27 while waiting for review of your submissions: your images will appear as no larger than thumbnails, at no more than 300 pixels wide... so if you want your text to be more meaningful than colour & pattern gradients then you could take some closer crops of more specific features.

@katomm
Copy link
Member

katomm commented Oct 18, 2024

Hey @Fell-x27 thank you for this, also for bringing this tool to the Ambassador Call in October. What I found odd is that entry here links to https://github.com/cardano-community/cfd

But the quick start the pulls from your personal repo:
git clone https://github.com/Fell-x27/cfd.git

(I assume this is because it was brought to Cardano-community repo recently)

@katomm
Copy link
Member

katomm commented Oct 18, 2024

Unrelated: build failing atm is not because of this PR, but: (#1335 for ref)

Error:  Loading of version failed for version current
Error:  Unable to build website for locale en.
Error:  Error: Can't process doc metadata for doc at path path=/github/workspace/docs/governance/cardano-improvement-proposals/CIP-0127.md in version name=current
    at processDocMetadata (/github/workspace/node_modules/@docusaurus/plugin-content-docs/lib/docs.js:200:15)
    at async Promise.all (index 197)

@Fell-x27
Copy link
Contributor Author

I assume this is because it was brought to Cardano-community repo recently

Yep. They are both in sync, so I can't change it. But it's ok. Cardano-community repo is a permanent-synced fork. I push to both repos simultaneously :)

while waiting for review of your submissions: your images will appear as no larger than thumbnails, at no more than 300 pixels wide...

CFD's preview is 994x437.
pg_cardano's preview is 1046x760.

I've checked it on the local version of the developer portal, and everything was fine. It's nothing but splashes or "better than nothing". Maybe later I'll replace them with logos if any appear.

@rphair rphair merged commit 0f52d24 into cardano-foundation:staging Oct 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder tool Indicates a PR/issue on a builder tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants